Fix skipif for mkfifo usage in gh20582.phpt #20804
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it like ext/standard/tests/file/filetype_variation.phpt; it's not just Windows that can have a missing posix_mkfifo, but also a minimal build, like the ones suggested that RMs (using --disable-all).
DanielEScherzer
approved these changes
Dec 30, 2025
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Also failed when building PHP 8.5.2RC1 because the function was missing
ndossche
approved these changes
Dec 30, 2025
Member
|
As release managers we (@NattyNarwhal and I) should both have bypass rights, I see a "Merge without waiting for requirements to be met (bypass rules)" checkbox option |
Member
Author
The test doesn't seem to exist in PHP-8.2, so I made it target PHP-8.3. If the fix it's testing is present, should the whole test be backported to 8.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it like ext/standard/tests/file/filetype_variation.phpt; it's not just Windows that can have a missing posix_mkfifo, but also a minimal build, like the ones suggested that RMs test with (using --disable-all).